[libcxx-commits] [PATCH] D123912: [libc++] Granularize <functional> includes

Mark de Wever via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Wed Apr 20 11:42:10 PDT 2022


Mordante accepted this revision.
Mordante added a comment.
This revision is now accepted and ready to land.

Nice cleanup, LGTM!



================
Comment at: libcxx/include/experimental/coroutine:52
 #include <experimental/__config>
-#include <functional>
+#include <functional> // TODO: Remove this include
 #include <memory> // for hash<T*>
----------------
I wonder do we need to update this header? It's slated for removal.


================
Comment at: libcxx/include/numeric:150
 #include <cmath> // for isnormal
-#include <functional>
+#include <functional> // TODO: Remove this include
 #include <iterator>
----------------
Interesting to see how many headers include this header and don't use it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123912/new/

https://reviews.llvm.org/D123912



More information about the libcxx-commits mailing list