[libcxx-commits] [PATCH] D123851: [libc++] Change vector<bool>::const_iterator::reference to bool in ABIv2

[Mark de Wever via Phabricator via libcxx-commits]

Mordante added a comment.

I see `_LIBCPP_ABI_BITSET_VECTOR_BOOL_CONST_SUBSCRIPT_RETURN_BOOL` isn't mentioned in the release notes, can you add an entry?

LGTM modulo some small nits.



================
Comment at: libcxx/test/std/containers/sequences/vector.bool/iterators.pass.cpp:35
+    ASSERT_SAME_TYPE(ConstIterRefT, std::__bit_const_reference<std::vector<bool> >);
+#endif
     {
----------------
Interestingly the test `libcxx/test/std/containers/sequences/vector.bool/types.pass.cpp` isn't affected.

It would be nice when you can add the `const_reference` to the synopsis and add tests for `pointer`, `const_pointer`, and `const_reference`. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123851/new/

https://reviews.llvm.org/D123851