[libcxx-commits] [PATCH] D124103: [libc++] Fixes concepts overload resolution.

[Mark de Wever via Phabricator via libcxx-commits]

Mordante marked an inline comment as done.
Mordante added a comment.

Thanks for the review!



================
Comment at: libcxx/include/__format/format_arg.h:163
 
-  _LIBCPP_HIDE_FROM_ABI explicit basic_format_arg(bool __v) noexcept
+  _LIBCPP_HIDE_FROM_ABI explicit basic_format_arg(const bool& __v) noexcept
       : __boolean(__v), __type_(__format::__arg_t::__boolean) {}
----------------
royjacobson wrote:
> I think here it's unnecessary because it's a specific type, but maybe you just preferred consistency?
This matches the wording of http://eel.is/c++draft/format.arg closer. (Note I use a const reference instead of an rvalue reference. This was the wording of an earlier revision of the Standard, changing it to an rvalue reference is work in progress.)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124103/new/

https://reviews.llvm.org/D124103