[libcxx-commits] [PATCH] D124103: [libc++] Fixes concepts overload resolution.

[Roy Jacobson via Phabricator via libcxx-commits]

royjacobson added a comment.

Thank you for the quick fix!

LGTM, small nit about the bool& change.



================
Comment at: libcxx/include/__format/format_arg.h:163
 
-  _LIBCPP_HIDE_FROM_ABI explicit basic_format_arg(bool __v) noexcept
+  _LIBCPP_HIDE_FROM_ABI explicit basic_format_arg(const bool& __v) noexcept
       : __boolean(__v), __type_(__format::__arg_t::__boolean) {}
----------------
I think here it's unnecessary because it's a specific type, but maybe you just preferred consistency?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124103/new/

https://reviews.llvm.org/D124103