[libcxx-commits] [PATCH] D121838: Generalize "check-all" umbrella targets, use for check-clang-tools

[Sam McCall via Phabricator via libcxx-commits]

sammccall added inline comments.


================
Comment at: llvm/cmake/modules/AddLLVM.cmake:1876
+    get_property(gather_names GLOBAL PROPERTY LLVM_LIT_UMBRELLAS)
+    set_property(GLOBAL APPEND PROPERTY LLVM_LIT_UMBRELLAS ${name})
+    foreach(name ${gather_names})
----------------
hokein wrote:
> I don't know where is the `name` variable? it seems at this point we don't have a name var (unlike the code in the `foreach(name ${gather_names})` below), I guess we probably should move it to the `foreach`?
Wow, this was accidentally copied from line 1842. I suppose it was "mostly harmless". Removed.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121838/new/

https://reviews.llvm.org/D121838