[libcxx-commits] [PATCH] D124011: [libc++] Always enable the ranges concepts

Mark de Wever via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Tue Apr 19 09:48:21 PDT 2022


Mordante added a comment.

This change was introduced in D118736 <https://reviews.llvm.org/D118736>, did you verify whether other part of the commit need to be reverted?
Did you verify whether there are unit tests that need to be reenabled?
(The packagers test the release branch so it would be good to have it there too.)



================
Comment at: libcxx/include/__ranges/concepts.h:71
 
-#if !defined(_LIBCPP_HAS_NO_INCOMPLETE_RANGES)
-
----------------
When removing this, please add some comment at the top of the file why this part of ranges isn't guarded by `_LIBCPP_HAS_NO_INCOMPLETE_RANGES`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124011/new/

https://reviews.llvm.org/D124011



More information about the libcxx-commits mailing list