[libcxx-commits] [PATCH] D114896: [runtimes][CI] Add a 10 minutes individual test time out

Nikolas Klauser via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Fri Apr 15 12:01:58 PDT 2022

philnik added a comment.

In D114896#3454353 <https://reviews.llvm.org/D114896#3454353>, @dblaikie wrote:

> Generally if something's sent for review it shouldn't be committed until it's approved. If you're looking to run the CI without review, you can use arc's --draft argument to produce a phab 'review' that isn't sent for review, this makes it clear whether something's intended for human review or not.

I think I disagree with you here. When people submit things for review even though they plan to just land it when CI passed it is a lot easier to see what people are up to and what changes (now matter how big) are made to the code base. libc++ is relatively small, so the changes easily affect other people's patches.

  rG LLVM Github Monorepo



More information about the libcxx-commits mailing list