[libcxx-commits] [PATCH] D123843: [lit][libcxx] Forward sanitizer environment

Fri Apr 15 11:59:17 PDT 2022

vitalybuka added a comment.

In D123843#3454456 <https://reviews.llvm.org/D123843#3454456>, @philnik wrote:

> In D123843#3454223 <https://reviews.llvm.org/D123843#3454223>, @vitalybuka wrote:
>
>> I want to be able to stuff like this:
>> MSAN_OPTIONS=poison_in_dtor=1 ninja check-libcxx
>
> I think the better option would be to add another lit configuration. Passing behaviour changing environment variables through makes the builds less reproducible, and here it seems to be quite simple to add it as a few flags.

Not sure I understand what is the proposal. Can you please clarify?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123843/new/

https://reviews.llvm.org/D123843