[libcxx-commits] [PATCH] D122092: [libc++] `bitset::operator[] const` should return bool

[Nikolas Klauser via Phabricator via libcxx-commits]

philnik added a comment.

In D122092#3452383 <https://reviews.llvm.org/D122092#3452383>, @rsmith wrote:

> Is it intentional that this leaves `std::vector<bool>::const_iterator::reference` as the class type? We're seeing some breakage in `absl` due to that.
>
> We're also seeing some breakage due to the result of `std::bitset::operator[]() const` no longer being convertible to `std::bitset::const_reference`, which would at least have been easier to understand if the `const_reference` typedef were removed entirely.

I just uploaded D123851 <https://reviews.llvm.org/D123851> for the `vector` part. I'm planning to look into removing `bitset::const_reference`, but since it shouldn't exist, nobody should use it anyways.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122092/new/

https://reviews.llvm.org/D122092