[libcxx-commits] [PATCH] D123600: [libc++][ranges] Implement `views::take`.

Thu Apr 14 15:59:04 PDT 2022

philnik added inline comments.

================
Comment at: libcxx/include/__fwd/string_view.h:1
+// -*- C++ -*-
+//===---------------------------------------------------------------------===//
----------------
huixie90 wrote:
> ldionne wrote:
> > philnik wrote:
> > > `__string_view/fwd.h` would make more sense I think. Same for `span`.
> > FWIW I don't really have a strong opinion. The only downside to this is that we might end up with a lot of one-header subdirectories if we start adding forward declarations to more classes, and putting everything under `__fwd/` would avoid that.
> I am in favour of fwd folder. I don’t like to have too many files with the exact same name fwd.hpp 
I don't like having a `__fwd` subdirectory because that would mean we have a single header spread across multiple subdirecories. That makes it a lot harder to see what is part of a header.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123600/new/

https://reviews.llvm.org/D123600