[libcxx-commits] [PATCH] D123580: [libc++] Use bit field for checking if string is in long or short mode

[Jorge Gorbe Moya via Phabricator via libcxx-commits]

jgorbe added inline comments.


================
Comment at: libcxx/utils/gdb/libcxx/printers.py:192
 
 class StdStringPrinter(object):
     """Print a std::string."""
----------------
Mordante wrote:
> philnik wrote:
> > Mordante wrote:
> > > philnik wrote:
> > > > Mordante wrote:
> > > > > Does this also break the LLDB pretty printer?
> > > > Probably. Would be nice to have a test runner for that.
> > > I already planned to look into that, D97044#3440904 ;-)
> > Do you know where I would have to look to know what the LLDB pretty printers do?
> Unfortunately no. @jingham seems to be the Data formatter code owner.
There was a recent lldb change fixing prettyprinters after a similar change to string: https://github.com/llvm/llvm-project/commit/45428412fd7c9900d3d6ac9803aa7dcf6adfa6fe

If the gdb prettyprinter needed fixing for this change, chances are that lldb will need a similar update too.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123580/new/

https://reviews.llvm.org/D123580