[libcxx-commits] [PATCH] D122806: [libc++] add zip_view and views::zip for C++23

[Nikolas Klauser via Phabricator via libcxx-commits]

philnik accepted this revision as: philnik.
philnik added a comment.

This LGTM. Let's see what @var-const thinks.



================
Comment at: libcxx/test/std/ranges/range.adaptors/range.zip/iterator/iter_move.pass.cpp:28
+
+constexpr bool test() {
+  {
----------------
huixie90 wrote:
> philnik wrote:
> > philnik wrote:
> > > You should check here that the `iter_move` of the iterator is called properly.
> > I think you aren't checking that a custom `iter_move` is called properly. This should be quite similar to the `iter_swap` test.
> Could you please elaborate? The `iter_move` test looks really similar to `iter_swap` test
Yes, sorry. I don't know what I was looking for, but it looks good.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122806/new/

https://reviews.llvm.org/D122806