[libcxx-commits] [PATCH] D122092: [libc++] `bitset::operator const` should return bool
Louis Dionne via Phabricator via libcxx-commits
libcxx-commits at lists.llvm.org
Wed Apr 13 07:21:47 PDT 2022
ldionne accepted this revision.
ldionne added a comment.
LGTM, but I would really like to investigate removing `const_reference` from `bitset` altogether, since there isn't one in the Standard. It's a rather bad API to provide a typedef called `const_reference` that isn't a reference, and in fact it leads to the very confusion we are removing an extension for. I'd rather break people's source (considering there probably isn't too many users of `bitset::const_reference` out there) than give them an API that is both non-standard and error-prone.
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
More information about the libcxx-commits