[libcxx-commits] [PATCH] D122536: [libc++] Optimize `exception_ptr`, especially for the empty case

Fabian Wolff via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Tue Apr 12 08:27:21 PDT 2022


fwolff marked an inline comment as done.
fwolff added inline comments.


================
Comment at: libcxx/src/support/runtime/exception_pointer_cxxabi.ipp:21
+#endif // _LIBCPP_ABI_OPTIMIZED_EXCEPTION_PTR
   __cxa_decrement_exception_refcount(__ptr_);
 }
----------------
philnik wrote:
> Is there a reason for this additional indirection?
There are two implementations of `__incr/decr_refcount()`, one here and one in `exception_pointer_unimplemented.ipp`. But maybe the latter one is unnecessary? I'm not sure.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122536/new/

https://reviews.llvm.org/D122536



More information about the libcxx-commits mailing list