[libcxx-commits] [PATCH] D123600: [libc++][ranges] Implement `views::take`.

[Joe Loser via Phabricator via libcxx-commits]

jloser added inline comments.


================
Comment at: libcxx/include/__fwd/string_view.h:20-35
+_LIBCPP_BEGIN_NAMESPACE_STD
+
+template<class _CharT, class _Traits = char_traits<_CharT> >
+class _LIBCPP_TEMPLATE_VIS basic_string_view;
+
+typedef basic_string_view<char>     string_view;
+#ifndef _LIBCPP_HAS_NO_CHAR8_T
----------------
philnik wrote:
> Shouldn't `string_view` be C++17 or later?
Technically yes, but for `libc++`, no. We support `string_view` in older standards as an extension. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123600/new/

https://reviews.llvm.org/D123600