[libcxx-commits] [PATCH] D123428: [libunwind] Add configuration to disable sigreturn frame check

[Ryan Prichard via Phabricator via libcxx-commits]

rprichard added a comment.

> ... that's still subject to time-of-check-to-time-of-use issues

Using /proc/self/maps would be subject to TOCTOU, but I think most methods wouldn't, e.g.:

- Open /proc/self/mem and pread() the address. This seems strictly better than /proc/self/maps?
- Create a pipe using pipe(), write() the bytes into the pipe buffer and read() them back out. I believe a Linux pipe buffer is guaranteed to be big enough (>= 8 bytes).
- process_vm_readv

I wonder if security configurations are a problem. Maybe I should experiment on an Android build.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123428/new/

https://reviews.llvm.org/D123428