[libcxx-commits] [PATCH] D118809: [libc++] Define `namespace views` in its own detail header.

[Louis Dionne via Phabricator via libcxx-commits]

ldionne added a comment.

In D118809#3437128 <https://reviews.llvm.org/D118809#3437128>, @dim wrote:

> It's a pity this one didn't make it into 14.0.0, as you now can't even include <ranges> without immediately getting an error:
>
>   % cat test-ranges.cpp
>   #include <ranges>
>   
>   % c++ -c test-ranges.cpp
>   In file included from test-ranges.cpp:1:
>   /usr/include/c++/v1/ranges:240:19: error: use of undeclared identifier 'ranges'
>   namespace views = ranges::views;
>                     ^
>   1 error generated.
>
> This should definitely go into 14.0.1, then?

Sorry, this missed 14.0.1 too, but I just cherry-picked it to the `release/14.x` branch:

  [libc++] Define `namespace views` in its own detail header.
  
  Discovered in the comments on D118748: we would like this namespace
  to exist anytime Ranges exists, regardless of whether concepts syntax
  is supported. Also, we'd like to fully granularize the <ranges> header,
  which means not putting any loose declarations at the top level.
  
  Differential Revision: https://reviews.llvm.org/D118809
  
  (cherry picked from commit 44cdca37c01a58da94087be8ebd0ee2bd2ba724e)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118809/new/

https://reviews.llvm.org/D118809