[libcxx-commits] [PATCH] D97044: [libc++] [C++2b] [P0943] Add stdatomic.h header.

Louis Dionne via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Mon Apr 11 07:34:54 PDT 2022

ldionne added a comment.

In D97044#3440904 <https://reviews.llvm.org/D97044#3440904>, @Mordante wrote:

> In D97044#3439970 <https://reviews.llvm.org/D97044#3439970>, @ldionne wrote:
>> Rebase onto main. @shafik, would you mind applying this patch locally to confirm that this version doesn't break the LLDB data formatter tests? I've tried running them myself but I am running into various errors.
>> The modules reproducer I had is now passing, so this should be fine, but I'd like to be real sure.
> @ldionne I'm wondering, how do you feel about adding LLDB and execute its tests in the Bootstrap build. (We've broken LLDB before and might have again D122598 <https://reviews.llvm.org/D122598>). Shall I provide a patch?

Yes, I would love that. I think we should only run the data formatters though, not all the tests. If those are not too expensive to run, I would run them in a separate job. I'm not sure we need to build all of Clang anyways, so including that in the Bootstrapping build might not save us that much work.

  rG LLVM Github Monorepo



More information about the libcxx-commits mailing list