[libcxx-commits] [PATCH] D122479: [libcxx] Rename PS() macro to avoid clashing with Xtensa register name

[Louis Dionne via Phabricator via libcxx-commits]

ldionne accepted this revision.
ldionne added a comment.
This revision is now accepted and ready to land.

LGTM, but I want to mention that this setup is broken for defining a non-namespaced macro with such a short name. It is bound to conflict with tons of other software, and it would be better to fix it in the OS header instead.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122479/new/

https://reviews.llvm.org/D122479