[libcxx-commits] [PATCH] D122614: [CMake][libcxx] Use target_include_directories for libc++ headers

[Louis Dionne via Phabricator via libcxx-commits]

ldionne accepted this revision.
ldionne added a comment.
This revision is now accepted and ready to land.

IIUC, CMake was basically ignoring the `target_include_directories(cxx-headers INTERFACE <path>)` previously because `<path>` was part of `${CMAKE_CXX_IMPLICIT_INCLUDE_DIRECTORIES}`? Hmm, that's a good find.

LGTM but can you please rebase onto `main` to get a clean CI run?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122614/new/

https://reviews.llvm.org/D122614