[libcxx-commits] [PATCH] D122877: [libc++] Implement P0401R6 (allocate_at_least)
Louis Dionne via Phabricator via libcxx-commits
libcxx-commits at lists.llvm.org
Fri Apr 8 13:44:36 PDT 2022
ldionne accepted this revision.
ldionne added a comment.
LGTM with added tests for `allocator::allocate_at_least`.
Comment at: libcxx/test/std/utilities/memory/default.allocator/allocator.members/allocate_at_least.pass.cpp:59
+ globalMemCounter.last_new_align = 0;
+ T* ap = a.allocate_at_least(3).ptr;
I think perhaps you copy-pasted from `libcxx/test/std/utilities/memory/default.allocator/allocator.members/allocate.pass.cpp` a bit too eagerly :-). We also need to test:
- The return type of `allocator::allocate_at_least`
- That the size member is `>=` to `ptr`
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
More information about the libcxx-commits