[libcxx-commits] [PATCH] D122534: [NFC][libc++][format] Prepare unit tests.

[Louis Dionne via Phabricator via libcxx-commits]

ldionne accepted this revision.
ldionne added a comment.
This revision is now accepted and ready to land.

LGTM with some comments.



================
Comment at: libcxx/test/std/utilities/format/format.functions/formatted_size.pass.cpp:27
 #include "test_macros.h"
 #include "format_tests.h"
 
----------------
I would prefer if the tests could include what they use -- here we're using `string_literal` but we haven't included `string_literal.h`. I think we should not rely on the transitive include via `format_tests.h`.


================
Comment at: libcxx/test/support/string_literal.h:47-50
+  char data_[N + 1];
+#  ifndef TEST_HAS_NO_WIDE_CHARACTERS
+  wchar_t wdata_[N + 1];
+#  endif
----------------
Should those be private?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122534/new/

https://reviews.llvm.org/D122534