[libcxx-commits] [PATCH] D122598: [libcxx] avoid using anonymous struct with base classes (fixes gcc-12)
Louis Dionne via Phabricator via libcxx-commits
libcxx-commits at lists.llvm.org
Thu Apr 7 07:46:53 PDT 2022
ldionne accepted this revision.
ldionne added a comment.
This revision is now accepted and ready to land.
And I just applied your original patch locally on my arm64 macbook air, ran the macOS 11 backdeployment testing, and I can see numerous tests failing because strings have an incorrect length. So this issue would have been caught with macOS arm64 backdeployment CI.
With this additional confidence, this LGTM if CI is passing. Please provide `Author Name <email at domain>` if you need us to commit this for you. Thanks!
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
More information about the libcxx-commits