[libcxx-commits] [PATCH] D122861: [libcxx] Add some missing xlocale wrapper functions for OpenBSD

[Brad Smith via Phabricator via libcxx-commits]

brad added inline comments.


================
Comment at: libcxx/include/__support/openbsd/xlocale.h:24
+
+static inline long strtol_l(const char *nptr, char **endptr, int base,
+                            locale_t) {
----------------
Mordante wrote:
> Why the `static inline` instead of `inline`?
> Please add `_LIBCPP_HIDE_FROM_ABI`.
> Why the `static inline` instead of `inline`?
> Please add `_LIBCPP_HIDE_FROM_ABI`.

I copied bits from libcxx/include/__support/solaris/xlocale.h, but the same goes for libcxx/include/__support/ibm/xlocale.h and libcxx/include/__support/musl/xlocale.h.

I don't see _LIBCPP_HIDE_FROM_ABI used anywhere in that sub-dir.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122861/new/

https://reviews.llvm.org/D122861