[libcxx-commits] [libcxxabi] dd8269c - [libc++abi] Remove XFAIL on arm64

[Louis Dionne via libcxx-commits]

Author: Louis Dionne
Date: 2022-04-06T19:08:01-04:00
New Revision: dd8269c54e9bf6f886cecb6df2aec9b90fcc645f

URL: https://github.com/llvm/llvm-project/commit/dd8269c54e9bf6f886cecb6df2aec9b90fcc645f
DIFF: https://github.com/llvm/llvm-project/commit/dd8269c54e9bf6f886cecb6df2aec9b90fcc645f.diff

LOG: [libc++abi] Remove XFAIL on arm64

The underlying TLS destruction order bug has been fixed in the OS. This
would technically still fail when running on top of macOS < 12, however
we don't have a good way of encoding that using Lit features. Indeed,
the existing target=<FOO> Lit feature encodes the deployment target,
not the actual runtime system that the tests are being run on.

If this test starts failing on your machine after this patch, upgrading
to macOS 12 should solve the problem.

Added: 
    

Modified: 
    libcxxabi/test/thread_local_destruction_order.pass.cpp

Removed: 
    


################################################################################
diff  --git a/libcxxabi/test/thread_local_destruction_order.pass.cpp b/libcxxabi/test/thread_local_destruction_order.pass.cpp
index 2c644ea40ce0b..c1e58f90c5110 100644
--- a/libcxxabi/test/thread_local_destruction_order.pass.cpp
+++ b/libcxxabi/test/thread_local_destruction_order.pass.cpp
@@ -9,9 +9,6 @@
 // UNSUPPORTED: c++03
 // UNSUPPORTED: libcxxabi-no-threads
 
-// TODO: Investigate this failure
-// XFAIL: target=arm64-apple-{{.+}}
-
 #include <cassert>
 #include <thread>