[libcxx-commits] [libcxx] 7594e23 - [libcxx] [test] Stop defining LIBCXX-WINDOWS-FIXME

[Martin Storsjö via libcxx-commits]

Author: Martin Storsjö
Date: 2022-04-06T22:54:39+03:00
New Revision: 7594e236795f695c7cf9336ee24ef76c275d8703

URL: https://github.com/llvm/llvm-project/commit/7594e236795f695c7cf9336ee24ef76c275d8703
DIFF: https://github.com/llvm/llvm-project/commit/7594e236795f695c7cf9336ee24ef76c275d8703.diff

LOG: [libcxx] [test] Stop defining LIBCXX-WINDOWS-FIXME

There are no such markings left - all of them have been fixed or
analyzed.

This closes llvm.org/PR32730 (github issue #32077).

Differential Revision: https://reviews.llvm.org/D123145

Added: 
    

Modified: 
    libcxx/test/configs/llvm-libc++-mingw.cfg.in
    libcxx/test/configs/llvm-libc++-shared-clangcl.cfg.in
    libcxx/test/configs/llvm-libc++-static-clangcl.cfg.in
    libcxx/utils/libcxx/test/config.py

Removed: 
    


################################################################################
diff  --git a/libcxx/test/configs/llvm-libc++-mingw.cfg.in b/libcxx/test/configs/llvm-libc++-mingw.cfg.in
index 32e83cdc7856e..0cb67936e00b9 100644
--- a/libcxx/test/configs/llvm-libc++-mingw.cfg.in
+++ b/libcxx/test/configs/llvm-libc++-mingw.cfg.in
@@ -14,13 +14,6 @@ config.substitutions.append(('%{exec}',
     '%{executor} --execdir %T --env PATH=%{lib} -- '
 ))
 
-# LIBCXX-WINDOWS-FIXME is the feature name used to XFAIL the
-# initial Windows failures until they can be properly diagnosed
-# and fixed. This allows easier detection of new test failures
-# and regressions. Note: New failures should not be suppressed
-# using this feature. (Also see llvm.org/PR32730)
-config.available_features.add('LIBCXX-WINDOWS-FIXME')
-
 import os, site
 site.addsitedir(os.path.join('@LIBCXX_SOURCE_DIR@', 'utils'))
 import libcxx.test.params, libcxx.test.newconfig

diff  --git a/libcxx/test/configs/llvm-libc++-shared-clangcl.cfg.in b/libcxx/test/configs/llvm-libc++-shared-clangcl.cfg.in
index 0ec64f6ecbf46..e8f1fc34442be 100644
--- a/libcxx/test/configs/llvm-libc++-shared-clangcl.cfg.in
+++ b/libcxx/test/configs/llvm-libc++-shared-clangcl.cfg.in
@@ -14,13 +14,6 @@ config.substitutions.append(('%{exec}',
     '%{executor} --execdir %T --env PATH=%{lib} -- '
 ))
 
-# LIBCXX-WINDOWS-FIXME is the feature name used to XFAIL the
-# initial Windows failures until they can be properly diagnosed
-# and fixed. This allows easier detection of new test failures
-# and regressions. Note: New failures should not be suppressed
-# using this feature. (Also see llvm.org/PR32730)
-config.available_features.add('LIBCXX-WINDOWS-FIXME')
-
 import os, site
 site.addsitedir(os.path.join('@LIBCXX_SOURCE_DIR@', 'utils'))
 import libcxx.test.params, libcxx.test.newconfig

diff  --git a/libcxx/test/configs/llvm-libc++-static-clangcl.cfg.in b/libcxx/test/configs/llvm-libc++-static-clangcl.cfg.in
index a407adb437b2f..2f408a09bf9ec 100644
--- a/libcxx/test/configs/llvm-libc++-static-clangcl.cfg.in
+++ b/libcxx/test/configs/llvm-libc++-static-clangcl.cfg.in
@@ -14,13 +14,6 @@ config.substitutions.append(('%{exec}',
     '%{executor} --execdir %T --env PATH=%{lib} -- '
 ))
 
-# LIBCXX-WINDOWS-FIXME is the feature name used to XFAIL the
-# initial Windows failures until they can be properly diagnosed
-# and fixed. This allows easier detection of new test failures
-# and regressions. Note: New failures should not be suppressed
-# using this feature. (Also see llvm.org/PR32730)
-config.available_features.add('LIBCXX-WINDOWS-FIXME')
-
 import os, site
 site.addsitedir(os.path.join('@LIBCXX_SOURCE_DIR@', 'utils'))
 import libcxx.test.params, libcxx.test.newconfig

diff  --git a/libcxx/utils/libcxx/test/config.py b/libcxx/utils/libcxx/test/config.py
index 4042e15d0f250..e025c4846c5ae 100644
--- a/libcxx/utils/libcxx/test/config.py
+++ b/libcxx/utils/libcxx/test/config.py
@@ -133,7 +133,6 @@ def configure(self):
         self.configure_env()
         self.configure_coverage()
         self.configure_substitutions()
-        self.configure_features()
 
         libcxx.test.newconfig.configure(
             libcxx.test.params.DEFAULT_PARAMETERS,
@@ -222,16 +221,6 @@ def configure_obj_root(self):
             else:
                 self.libcxx_obj_root = self.project_obj_root
 
-    def configure_features(self):
-        if self.target_info.is_windows():
-            if self.cxx_stdlib_under_test == 'libc++':
-                # LIBCXX-WINDOWS-FIXME is the feature name used to XFAIL the
-                # initial Windows failures until they can be properly diagnosed
-                # and fixed. This allows easier detection of new test failures
-                # and regressions. Note: New failures should not be suppressed
-                # using this feature. (Also see llvm.org/PR32730)
-                self.config.available_features.add('LIBCXX-WINDOWS-FIXME')
-
     def configure_compile_flags(self):
         self.configure_default_compile_flags()
         # Configure extra flags