[libcxx-commits] [PATCH] D122861: [libcxx] Add some missing xlocale wrapper functions for OpenBSD

[Mark de Wever via Phabricator via libcxx-commits]

Mordante added a comment.

I wonder whether this only affects OpenBSD or other platforms as well. If it also affects other platforms should these functions be here or in `_support/xlocale/__strtonum_fallback.h`?



================
Comment at: libcxx/include/__support/openbsd/xlocale.h:24
+
+static inline long strtol_l(const char *nptr, char **endptr, int base,
+                            locale_t) {
----------------
Why the `static inline` instead of `inline`?
Please add `_LIBCPP_HIDE_FROM_ABI`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122861/new/

https://reviews.llvm.org/D122861