[libcxx-commits] [PATCH] D123175: [libcxx] Add flag to turn on/off __builtin_assume in _LIBCPP_ASSERT

[Arthur Eubanks via Phabricator via libcxx-commits]

aeubanks added a comment.

In D123175#3432673 <https://reviews.llvm.org/D123175#3432673>, @ldionne wrote:

> Thanks for the patch @aeubanks. I agree with @philnik's suggestion, the macro should be "defined => no assume, undefined => assume". That way, it would be defined by default but we'd still have the escape hatch until we figure out issues with the builtin. Do you have an ETA for that (it's more than just this libc++ issue -- if Clang has a broken builtin, we need to fix it ASAP).

I don't have an ETA, so far I have one patch that only partially solves the very reduced case I was looking at, it still needs followup work and also followup investigation to see if there are any remaining issues.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123175/new/

https://reviews.llvm.org/D123175