[libcxx-commits] [PATCH] D123114: [libc++] Add __is_callable type trait and begin granularizing type_traits

[Louis Dionne via Phabricator via libcxx-commits]

ldionne accepted this revision.
ldionne added a comment.
This revision is now accepted and ready to land.

LGTM with green CI.



================
Comment at: libcxx/include/__type_traits/bool_constant.h:21
+
+typedef integral_constant<bool, true>  true_type;
+typedef integral_constant<bool, false> false_type;
----------------
Since those are so small, I would be in favor of putting them in `integral_constant.h` directly. I don't have a *strong* preference, though.


================
Comment at: libcxx/include/type_traits:1261
 
-// Suppress deprecation notice for volatile-qualified return type resulting
-// from volatile-qualified types _Tp.
----------------
For anyone looking at this and wondering the reason for this removal, we have the exact same code in `__utility/declval.h`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123114/new/

https://reviews.llvm.org/D123114