[libcxx-commits] [PATCH] D123175: [libcxx] Add flag to turn on/off __builtin_assume in _LIBCPP_ASSERT

Louis Dionne via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Wed Apr 6 05:55:05 PDT 2022


ldionne added a comment.

Thanks for the patch @aeubanks. I agree with @philnik's suggestion, the macro should be "defined => no assume, undefined => assume". That way, it would be defined by default but we'd still have the escape hatch until we figure out issues with the builtin. Do you have an ETA for that (it's more than just this libc++ issue -- if Clang has a broken builtin, we need to fix it ASAP).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123175/new/

https://reviews.llvm.org/D123175



More information about the libcxx-commits mailing list