[libcxx-commits] [libcxx] dba90d7 - [libcxx] Stop recommending setting LIBCXX_HAS_WIN32_THREAD_API in the MinGW builds

[Martin Storsjö via libcxx-commits]

Author: Martin Storsjö
Date: 2022-04-04T23:07:40+03:00
New Revision: dba90d74be330829c0ea0aea6c33182957b8b584

URL: https://github.com/llvm/llvm-project/commit/dba90d74be330829c0ea0aea6c33182957b8b584
DIFF: https://github.com/llvm/llvm-project/commit/dba90d74be330829c0ea0aea6c33182957b8b584.diff

LOG: [libcxx] Stop recommending setting LIBCXX_HAS_WIN32_THREAD_API in the MinGW builds

Since a8d15a926689c126c4d316788786e0160cfc1d5d / D110975, this is
the default, even if winpthread headers are available, so we don't
need to cargo cult setting this option in all builds.

Differential Revision: https://reviews.llvm.org/D122717

Added: 
    

Modified: 
    libcxx/cmake/caches/MinGW.cmake
    libcxx/docs/BuildingLibcxx.rst

Removed: 
    


################################################################################
diff  --git a/libcxx/cmake/caches/MinGW.cmake b/libcxx/cmake/caches/MinGW.cmake
index b9ac28006eb84..14b887e641012 100644
--- a/libcxx/cmake/caches/MinGW.cmake
+++ b/libcxx/cmake/caches/MinGW.cmake
@@ -1,5 +1,4 @@
 set(LIBCXX_ENABLE_EXPERIMENTAL_LIBRARY OFF CACHE BOOL "")
-set(LIBCXX_HAS_WIN32_THREAD_API ON CACHE BOOL "")
 
 set(LIBCXX_CXX_ABI libcxxabi CACHE STRING "")
 set(LIBCXXABI_USE_LLVM_UNWINDER ON CACHE BOOL "")

diff  --git a/libcxx/docs/BuildingLibcxx.rst b/libcxx/docs/BuildingLibcxx.rst
index da2219c28470f..e9f9271919d1c 100644
--- a/libcxx/docs/BuildingLibcxx.rst
+++ b/libcxx/docs/BuildingLibcxx.rst
@@ -159,7 +159,6 @@ e.g. the ``mingw-w64-x86_64-clang`` package), together with CMake and ninja.
           -DCMAKE_C_COMPILER=clang                                                    \
           -DCMAKE_CXX_COMPILER=clang++                                                \
           -DLLVM_ENABLE_RUNTIMES=libcxx                                               \
-          -DLIBCXX_HAS_WIN32_THREAD_API=ON                                            \
           -DLIBCXX_CXX_ABI=libstdc++                                                  \
           -DLIBCXX_TARGET_INFO="libcxx.test.target_info.MingwLocalTI"
   > ninja -C build cxx