[libcxx-commits] [PATCH] D122717: [libcxx] Stop recommending setting LIBCXX_HAS_WIN32_THREAD_API in the MinGW builds

Martin Storsjö via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Mon Apr 4 13:07:59 PDT 2022


This revision was automatically updated to reflect the committed changes.
Closed by commit rGdba90d74be33: [libcxx] Stop recommending setting LIBCXX_HAS_WIN32_THREAD_API in the MinGW… (authored by mstorsjo).

Changed prior to commit:
  https://reviews.llvm.org/D122717?vs=419094&id=420287#toc

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122717/new/

https://reviews.llvm.org/D122717

Files:
  libcxx/cmake/caches/MinGW.cmake
  libcxx/docs/BuildingLibcxx.rst


Index: libcxx/docs/BuildingLibcxx.rst
===================================================================
--- libcxx/docs/BuildingLibcxx.rst
+++ libcxx/docs/BuildingLibcxx.rst
@@ -159,7 +159,6 @@
           -DCMAKE_C_COMPILER=clang                                                    \
           -DCMAKE_CXX_COMPILER=clang++                                                \
           -DLLVM_ENABLE_RUNTIMES=libcxx                                               \
-          -DLIBCXX_HAS_WIN32_THREAD_API=ON                                            \
           -DLIBCXX_CXX_ABI=libstdc++                                                  \
           -DLIBCXX_TARGET_INFO="libcxx.test.target_info.MingwLocalTI"
   > ninja -C build cxx
Index: libcxx/cmake/caches/MinGW.cmake
===================================================================
--- libcxx/cmake/caches/MinGW.cmake
+++ libcxx/cmake/caches/MinGW.cmake
@@ -1,5 +1,4 @@
 set(LIBCXX_ENABLE_EXPERIMENTAL_LIBRARY OFF CACHE BOOL "")
-set(LIBCXX_HAS_WIN32_THREAD_API ON CACHE BOOL "")
 
 set(LIBCXX_CXX_ABI libcxxabi CACHE STRING "")
 set(LIBCXXABI_USE_LLVM_UNWINDER ON CACHE BOOL "")


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D122717.420287.patch
Type: text/x-patch
Size: 1141 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20220404/12e13b73/attachment.bin>


More information about the libcxx-commits mailing list