[libcxx-commits] [PATCH] D122397: [libc++] Use __builtin_expect and __builtin_assume in _LIBCPP_ASSERT

Mon Apr 4 10:59:55 PDT 2022

ldionne added a comment.

In D122397#3427001 <https://reviews.llvm.org/D122397#3427001>, @aeubanks wrote:

> Just a heads up, we've bisected some leaks to this change. There are some calls to operator new that aren't be optimized away because they're now the subject of various `llvm.assume()` calls. Still investigating.

Ugh, thanks for the heads up. Please keep me in the loop (here or ideally in Discord so I don't miss it). I'm open to removing `__builtin_assume` until the issue is fixed if it gets to that.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122397/new/

https://reviews.llvm.org/D122397