[libcxx-commits] [PATCH] D123055: [libc++] Tidy up tests for deduction guides and other compile-time failing properties in std::string

[Louis Dionne via Phabricator via libcxx-commits]

ldionne created this revision.
Herald added a project: All.
ldionne requested review of this revision.
Herald added a project: libc++.
Herald added a subscriber: libcxx-commits.
Herald added a reviewer: libc++.

Instead of using `.fail.cpp` tests, use `.verify.cpp` to check for the
exact reason of the failure. In the case of deduction guides, use SFINAE
based tests instead since that is our preferred way of testing those.

Finally, ensure that we actually run the test in `iter_alloc_deduction.pass.cpp`,
since we were not running anything before.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D123055

Files:
  libcxx/test/std/strings/basic.string/allocator_mismatch.compile.fail.cpp
  libcxx/test/std/strings/basic.string/allocator_mismatch.verify.cpp
  libcxx/test/std/strings/basic.string/char.bad.fail.cpp
  libcxx/test/std/strings/basic.string/char.bad.verify.cpp
  libcxx/test/std/strings/basic.string/string.cons/iter_alloc_deduction.fail.cpp
  libcxx/test/std/strings/basic.string/string.cons/iter_alloc_deduction.pass.cpp
  libcxx/test/std/strings/basic.string/string.cons/string_view.compile.fail.cpp
  libcxx/test/std/strings/basic.string/string.cons/string_view.pass.cpp
  libcxx/test/std/strings/basic.string/string.cons/string_view_deduction.fail.cpp
  libcxx/test/std/strings/basic.string/string.cons/string_view_deduction.pass.cpp
  libcxx/test/std/strings/basic.string/string.cons/string_view_size_size_deduction.fail.cpp
  libcxx/test/std/strings/basic.string/string.cons/string_view_size_size_deduction.pass.cpp
  libcxx/test/std/strings/basic.string/traits_mismatch.compile.fail.cpp
  libcxx/test/std/strings/basic.string/traits_mismatch.verify.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D123055.420238.patch
Type: text/x-patch
Size: 17639 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20220404/cb03c175/attachment-0001.bin>