[libcxx-commits] [PATCH] D123016: [libc++] Implement ranges::{all, any, none}_of

[Louis Dionne via Phabricator via libcxx-commits]

ldionne added inline comments.


================
Comment at: libcxx/include/__algorithm/ranges_all_of.h:35
+  _LIBCPP_HIDE_FROM_ABI constexpr static
+  bool __go(_Iter __first, _Sent __last, _Pred& __pred, _Proj& __proj) {
+    for (; __first != __last; ++__first) {
----------------
I suggested naming these helpers `__all_of_impl` in a previous review (I think we had agreed on the naming scheme). I assume this slipped because you already had this patch locally when I made the comment, but please make sure to rebase all your local patches with my comments to make sure nothing slips through the cracks.

You can then ping me when you think this is ready for review.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123016/new/

https://reviews.llvm.org/D123016