[libcxx-commits] [PATCH] D122092: [libc++] `bitset::operator[] const` should return bool

[Nikolas Klauser via Phabricator via libcxx-commits]

philnik added inline comments.


================
Comment at: libcxx/test/std/containers/sequences/vector.bool/const_reference.pass.cpp:16
+
+bool test() {
+  using CRefT = std::vector<bool>::const_reference;
----------------
var-const wrote:
> philnik wrote:
> > var-const wrote:
> > > Optional nit: since this test isn't `constexpr`, it doesn't need to return anything -- unless you expect it to become `constexpr` at some future point?
> > This test should become `constexpr` once we implement P1004R2.
> In that case, can you please add a TODO?
I don't think adding a TODO makes a lot of sense here. When implementing P1004R2 almost every single file inside `vector.bool` and `vector` have to be changed anyways.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122092/new/

https://reviews.llvm.org/D122092