[libcxx-commits] [PATCH] D122614: [CMake][libcxx] Use target_include_directories for libc++ headers

[Nathan Sidwell via Phabricator via libcxx-commits]

urnathan added inline comments.


================
Comment at: runtimes/CMakeLists.txt:95
 
+# See https://gitlab.kitware.com/cmake/cmake/-/issues/19227 to why this is needed.
+set(CMAKE_C_IMPLICIT_INCLUDE_DIRECTORIES "")
----------------
maybe put a precis of 19227 here (as well as the reference), I like comments but I am the new kid :)
IIUC it's because were doing the clang equivalent of gcc's -nostdinc?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122614/new/

https://reviews.llvm.org/D122614