[libcxx-commits] [PATCH] D122718: [libcxx] [test] Avoid spurious test breakage in clang-cl-dll configs with newer CMake

Martin Storsjö via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Fri Apr 1 00:15:23 PDT 2022

This revision was automatically updated to reflect the committed changes.
Closed by commit rGb048397db802: [libcxx] [test] Avoid spurious test breakage in clang-cl-dll configs with newer… (authored by mstorsjo).

  rG LLVM Github Monorepo




Index: libcxx/test/std/input.output/iostream.format/output.streams/ostream.formatted/ostream.inserters.arithmetic/pointer.volatile.pass.cpp
--- libcxx/test/std/input.output/iostream.format/output.streams/ostream.formatted/ostream.inserters.arithmetic/pointer.volatile.pass.cpp
+++ libcxx/test/std/input.output/iostream.format/output.streams/ostream.formatted/ostream.inserters.arithmetic/pointer.volatile.pass.cpp
@@ -10,12 +10,22 @@
 // UNSUPPORTED: c++03, c++11, c++14, c++17, c++20
-// This test fails on MinGW DLL configurations, due to
+// This test fails in Windows DLL configurations, due to
 // __exclude_from_explicit_instantiation__ not behaving as it should in
 // combination with dllimport (https://llvm.org/PR41018), in combination
 // with running tests in c++2b mode while building the library in c++20 mode.
-// (If the library was built in c++2b mode, this test would succeed.)
-// XFAIL: target={{.+}}-windows-gnu && windows-dll
+// If the library was built in c++2b mode, this test would succeed.
+// Older CMake passed -std:c++latest to set C++ 20 mode on clang-cl, which
+// hid this issue. With newer CMake versions, it passes -std:c++20 which
+// makes this fail.
+// Marking as UNSUPPORTED instead of XFAIL to avoid spurious failures/successes
+// depending on the version of CMake used.
+// TODO: Remove this when the library is built in c++2b mode.
+// UNSUPPORTED: windows-dll
 // template <class charT, class traits = char_traits<charT> >
 //   class basic_ostream;

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D122718.419648.patch
Type: text/x-patch
Size: 1585 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20220401/db60e2a2/attachment.bin>

More information about the libcxx-commits mailing list