[libcxx-commits] [PATCH] D88458: [CMake] Cache the compiler-rt library search results

Wed Sep 29 02:11:05 PDT 2021

phosek added a comment.

In D88458#3019076 <https://reviews.llvm.org/D88458#3019076>, @dexonsmith wrote:

> In D88458#3013817 <https://reviews.llvm.org/D88458#3013817>, @beanz wrote:
>
>> In D88458#3013813 <https://reviews.llvm.org/D88458#3013813>, @dexonsmith wrote:
>>
>>> There's no LICENSE.TXT file at the top level so there isn't one that clearly applies to the new `cmake/`. Should `compiler-rt/LICENSE.TXT` be copied to `cmake/LICENSE.TXT`?
>>
>> Is there any reason not to just put one at the top now?
>
> This was suggested before and there wasn't consensus for change. See https://reviews.llvm.org/D64875.

I don't mind adding a license file, but we also seem to be missing one for other top-level directories that were added recently like `cross-project-tests`, `runtimes` or `utils` so I wonder if this is something that needs to be addressed more broadly?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88458/new/

https://reviews.llvm.org/D88458