[libcxx-commits] [PATCH] D110870: [libc++] Rename the 'libc++' Lit feature to 'llvm-libc++'

[Arthur O'Dwyer via Phabricator via libcxx-commits]

Quuxplusone added inline comments.


================
Comment at: libcxx/test/std/utilities/function.objects/func.search/func.search.bmh/hash.pred.pass.cpp:10
 // UNSUPPORTED: c++03, c++11, c++14
-// XFAIL: stdlib=libc++
 
----------------
Off-topic, but what on earth? Why does libc++'s test suite have test cases that are XFAILed //on libc++?//


================
Comment at: libcxx/utils/libcxx/test/params.py:105
+                 - msvc: The Microsoft implementation of the C++ Standard Library.
+                """,
             actions=lambda stdlib: [
----------------
I don't really know the use-case here, but maybe consider whether you want to
- call the non-Apple case `upstream-libc++` or `trunk-libc++` instead of `llvm-libc++`
- have an umbrella `libc++` feature which can be `REQUIRE`'d against, in addition to the finer-grained subfeatures. (This would let you avoid changing the test suite at all. Any day we can avoid introducing regexes into the test suite, is a good day.)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110870/new/

https://reviews.llvm.org/D110870