[libcxx-commits] [PATCH] D110736: [libc++][libc++abi] Add tests for vendor-specific properties

Thu Sep 30 11:29:46 PDT 2021

ldionne reopened this revision.
ldionne added a comment.
This revision is now accepted and ready to land.

In D110736#3034269 <https://reviews.llvm.org/D110736#3034269>, @haowei wrote:

> Changed reverted in 138dc27186bed4565584387fc49d88b235a1e2ed <https://reviews.llvm.org/rG138dc27186bed4565584387fc49d88b235a1e2ed> as author did not respond.
> This change broke all of our builders for more than 12hrs.

Thanks for reverting, and sorry for not noticing earlier, but for my defence the first ping happened way after I was off work yesterday. Also, in the future, folks can try to reach out on the #libcxx Discord channel, it's usually the fastest way to get a hold of me (there's a lot of Phabricator emails and this got lost in the noise all morning).

Our CI was green (https://buildkite.com/llvm-project/libcxx-ci/builds/5628). I'm going to look into what happened, I think we are not properly testing `libunwind` anywhere and that's why the issue went unnoticed.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110736/new/

https://reviews.llvm.org/D110736