[libcxx-commits] [PATCH] D110846: [libcxx] Make allocator<T>:allocate throw bad_array_new_length

[Arthur O'Dwyer via Phabricator via libcxx-commits]

Quuxplusone added a comment.

//I// like this, but @ldionne needs to look.



================
Comment at: libcxx/docs/Status/Cxx20Issues.csv:165
 "`3225 <https://wg21.link/LWG3225>`__","``zoned_time``\  converting constructor shall not be ``noexcept``\ ","Belfast","",""
-"`3190 <https://wg21.link/LWG3190>`__","``std::allocator::allocate``\  sometimes returns too little storage","Belfast","",""
+"`3190 <https://wg21.link/LWG3190>`__","``std::allocator::allocate``\  sometimes returns too little storage","Belfast","|Complete|",""
 "`3218 <https://wg21.link/LWG3218>`__","Modifier for ``%d``\  parse flag does not match POSIX and ``format``\  specification","Belfast","",""
----------------
Here and above: `s/""/"14.0"/`?


================
Comment at: libcxx/include/experimental/memory_resource:187
+        if (__n > __max_size())
+            __libcpp_throw_bad_array_new_length();
         return static_cast<_ValueType*>(
----------------
For the record: Personally I don't think it matters whether we change `experimental::pmr::polymorphic_allocator` or not. I //have// adopted this patch into my next update of D89057 (`std::pmr::polymorphic_allocator`).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110846/new/

https://reviews.llvm.org/D110846