[libcxx-commits] [PATCH] D110718: [libc++] Implement P1391

[Mark de Wever via Phabricator via libcxx-commits]

Mordante accepted this revision as: Mordante.
Mordante added a comment.

LGTM, except for some small details.



================
Comment at: libcxx/test/std/strings/string.view/string.view.cons/deduct.pass.cpp:34
+  test<wchar_t>();
+  test<char8_t>();
+  test<char16_t>();
----------------
`char8_t` should be guarded by `#ifndef _LIBCPP_HAS_NO_CHAR8_T`.


================
Comment at: libcxx/test/std/strings/string.view/string.view.cons/from_iterator_iterator.pass.cpp:22
+template<class CharT>
+constexpr bool test() {
+  auto str = MAKE_STRING_VIEW(CharT, "test");
----------------
This function can be a `void`.


================
Comment at: libcxx/test/support/make_string.h:61
+#define MAKE_STRING_VIEW(CharT, Str)                                                \
+  std::basic_string_view<CharT> {                                                   \
+    static_cast<const CharT*>(MultiStringType MKSTR(Str))                      \
----------------
Please align the `\` at the end of the line.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110718/new/

https://reviews.llvm.org/D110718