[libcxx-commits] [PATCH] D110794: [libc++][test] NFC: Don't include name in banner comment

[Mark de Wever via Phabricator via libcxx-commits]

Mordante added a comment.

I really like the removal of the filename, I've seen it copy-pasted in new files too often, without an update of the name.



================
Comment at: libcxx/test/std/containers/views/span.cons/array.fail.cpp:1
-// -*- C++ -*-
-//===------------------------------ span ---------------------------------===//
----------------
Your description says you want to do that in a separate commit, or what do you exactly mean there?


================
Comment at: libcxx/test/std/containers/views/span.cons/array.fail.cpp:1
-// -*- C++ -*-
-//===------------------------------ span ---------------------------------===//
+//===----------------------------------------------------------------------===//
 //
----------------
Mordante wrote:
> Your description says you want to do that in a separate commit, or what do you exactly mean there?
Why is the line now one character longer?
It now looks this line is one character longer than line 7.


================
Comment at: libcxx/test/support/constexpr_char_traits.h:1
-// -*- C++ -*-
-//===-------------------- constexpr_char_traits ---------------------------===//
----------------
I prefer to keep these in the header files .h can be a c or c++ file.
IMO removing them has little benefit and might break somebodies setup.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110794/new/

https://reviews.llvm.org/D110794