[libcxx-commits] [PATCH] D110736: [libc++][libc++abi] Add tests for vendor-specific properties

[Leonard Chan via Phabricator via libcxx-commits]

leonardchan added a comment.

Hi. I think this patch may be what's causing the errors we're seeing on our builders (https://luci-milo.appspot.com/p/fuchsia/builders/toolchain.ci/clang-linux-x64/b8834719104333485313):

  llvm-lit: /b/s/w/ir/x/w/llvm-project/llvm/utils/lit/lit/TestingConfig.py:102: fatal: unable to parse config file '/b/s/w/ir/x/w/staging/llvm_build/runtimes/runtimes-x86_64-unknown-linux-gnu-bins/libunwind/test/lit.site.cfg', traceback: Traceback (most recent call last):
    File "/b/s/w/ir/x/w/llvm-project/llvm/utils/lit/lit/TestingConfig.py", line 91, in load_from_path
      exec(compile(data, path, 'exec'), cfg_globals, None)
    File "/b/s/w/ir/x/w/staging/llvm_build/runtimes/runtimes-x86_64-unknown-linux-gnu-bins/libunwind/test/lit.site.cfg", line 60, in <module>
      configuration.configure()
    File "/b/s/w/ir/x/w/llvm-project/libcxx/utils/libcxx/test/config.py", line 135, in configure
      self.configure_substitutions()
    File "/b/s/w/ir/x/w/llvm-project/libcxx/utils/libcxx/test/config.py", line 470, in configure_substitutions
      sub.append(('%{install}',       self.quote(self.config.install_root)))
  AttributeError: 'TestingConfig' object has no attribute 'install_root'

Would you be able to send out a fix or revert? Thanks.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110736/new/

https://reviews.llvm.org/D110736