[libcxx-commits] [PATCH] D110573: [libc++] Adds back_insert_iterator::__get_container.

[Arthur O'Dwyer via Phabricator via libcxx-commits]

Quuxplusone accepted this revision as: Quuxplusone.
Quuxplusone added a comment.

Presumably you should wait to land this until it's actually needed by <format>, so we don't have a loose wire hanging around for too long without being hooked up to something.
The `_LIBCPP_HIDE_FROM_ABI` refactoring could just be landed ASAP, AFAIconcerned.



================
Comment at: libcxx/include/__iterator/back_insert_iterator.h:59
+
+    _LIBCPP_HIDE_FROM_ABI _LIBCPP_CONSTEXPR_AFTER_CXX17 _Container* __get_container() { return container; }
 };
----------------
> Making the function a const member function has little use

Agreed, but it has non-negative use, and it's conventional (in that it doesn't modify any of `*this`'s members), so I think you should make it `const` just for consistency.

Otherwise LGTM!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110573/new/

https://reviews.llvm.org/D110573