[libcxx-commits] [PATCH] D110598: [libc++] P0980R1 (constexpr std::string)

Tue Sep 28 10:49:24 PDT 2021

smeenai added inline comments.

================
Comment at: libcxx/include/string:1117
     template <class _Tp>
-    _LIBCPP_METHOD_TEMPLATE_IMPLICIT_INSTANTIATION_VIS
+    _LIBCPP_METHOD_TEMPLATE_IMPLICIT_INSTANTIATION_VIS _LIBCPP_CONSTEXPR_AFTER_CXX17
     __enable_if_t
----------------
Quuxplusone wrote:
> [FUD alert] I wonder whether there is any weird interaction between this unusual `_LIBCPP_METHOD_TEMPLATE_IMPLICIT_INSTANTIATION_VIS` specifier and `constexpr`. D29157 is the PR that introduced `_LIBCPP_METHOD_TEMPLATE_IMPLICIT_INSTANTIATION_VIS`; maybe @smeenai remembers what the deal was and whether `constexpr` is going to mess anything up.
It's been a while, but I can't think of any possible interactions between that and `constexpr`.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110598/new/

https://reviews.llvm.org/D110598