[libcxx-commits] [PATCH] D110144: [libunwind] Support cfi_undefined and cfi_register for float registers.

[Martin Storsjö via Phabricator via libcxx-commits]

mstorsjo added a comment.

This broke building for armv7-mingw. The `Register_arm` version of `getFloatRegister()` is not const, contrary to the other `getFloatRegister()` implementations for other architectures. It's not a plain oversight, as `Registers_arm::getFloatRegister` has a bunch of logic for fetching the relevant register banks (VFP 0-15, VFP 16-31 or WMMX) if not yet fetched, so it can't be made const easily. And I don't think it's a place where it's necessarily right to make the member variables `mutable` either...


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110144/new/

https://reviews.llvm.org/D110144