[libcxx-commits] [PATCH] D89013: [libcxx] Support per-target __config_site in per-target runtime build

[Petr Hosek via Phabricator via libcxx-commits]

phosek added a comment.

In D89013#3022332 <https://reviews.llvm.org/D89013#3022332>, @sylvestre.ledru wrote:

> @phosek
> It was probably my fault (mix of different in-tree / out of tree builds)
> Quick question, why the path to `__config_site` contains this triple
> `x86_64-pc-linux-gnu`
> (in `/usr/lib/llvm-14/include/x86_64-pc-linux-gnu/c++/v1/__config_site`)
> when it is usually:
> `x86_64-linux-gnu`
> (does not contain `-pc`)
> thanks?

See the comments earlier in this review (such as https://reviews.llvm.org/D89013#2662244) where we discussed whether to use Debian multiarch triples or normalized LLVM triples. We've decided to use normalized LLVM triples to reduce the amount of custom logic needed and increase consistency across platforms.

The reason why `__config_site` uses `x86_64-pc-linux-gnu` is because that's the default target that was used by the build (you can also override it via `-DLLVM_DEFAULT_TARGET_TRIPLE=`). We would normalize `x86_64-linux-gnu` to `x86_64-unknown-linux-gnu`. The `-pc` vendor component was returned by the `config.guess` script, I believe that's going to be addressed by removal of that script in D109837 <https://reviews.llvm.org/D109837>.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89013/new/

https://reviews.llvm.org/D89013