[libcxx-commits] [PATCH] D110503: [libc++] Implement P1394r4 for span: range constructor

Joe Loser via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Mon Sep 27 07:30:02 PDT 2021


jloser updated this revision to Diff 375252.
jloser added a comment.

Address some review feedback:

- Add some #ifdef for ranges support in span
- s/__is_range_compatible/__is_span_compatible_range
- Simplify deduction guides to use concepts rather than enable_if_t
- Consistent SFINAE using = nullptr
- ADL proof to_address and distance
- Fix exposition with conditional explicitness on range constructor for span


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110503/new/

https://reviews.llvm.org/D110503

Files:
  libcxx/include/span
  libcxx/test/std/containers/views/span.cons/container.fail.cpp
  libcxx/test/std/containers/views/span.cons/container.pass.cpp
  libcxx/test/std/containers/views/span.cons/deduct.pass.cpp
  libcxx/test/std/containers/views/span.cons/iterator_iterator.fail.cpp
  libcxx/test/std/containers/views/span.cons/iterator_iterator.pass.cpp
  libcxx/test/std/containers/views/span.cons/iterator_len.fail.cpp
  libcxx/test/std/containers/views/span.cons/iterator_len.pass.cpp
  libcxx/test/std/containers/views/span.cons/ptr_len.fail.cpp
  libcxx/test/std/containers/views/span.cons/ptr_len.pass.cpp
  libcxx/test/std/containers/views/span.cons/ptr_ptr.fail.cpp
  libcxx/test/std/containers/views/span.cons/ptr_ptr.pass.cpp
  libcxx/test/std/containers/views/span.cons/range.fail.cpp
  libcxx/test/std/containers/views/span.cons/range.pass.cpp
  libcxx/test/std/containers/views/span.cons/simple_range.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D110503.375252.patch
Type: text/x-patch
Size: 72871 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20210927/c9f4da22/attachment-0001.bin>


More information about the libcxx-commits mailing list